Patch kustomize for GPUs to provision in regions without zones on Azure #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
bdattoma
changed the title
bdattoma
changed the title
bdattoma
added
verified
jstourac
previously approved these changes
Oct 3, 2024
lugi0
approved these changes
Oct 3, 2024
for some reasons adding a new line in my local branch of the file, doesn't mark the files as changed wrt remote branch..I tried to fix the new line error but I prefer not spending more time on it now. let's see if the warning disappears after the last sync I did |
|
jstourac
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support provisioning of GPUs in some regions of Azure where availability zone are not present we need to skip removal of "zone" key
Notes:
west usis the only one without zonesPR validation (on local CI):